fix: add useIsomorphicLayoutEffect to fix SSR warnings
#2503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🎭 Component Tests Report is ready. |
ValeraS
requested changes
Nov 18, 2025
src/hooks/private/useIsomorphicLayoutEffect/useIsomorphicLayoutEffect.ts
Outdated
Show resolved
Hide resolved
monochromer
changed the title
useIsomorphicLayoutEffect to fix SSR warningsuseIsomorphicLayoutEffect to fix SSR warnings
ValeraS
requested changes
Nov 18, 2025
ValeraS
requested changes
Nov 19, 2025
Collaborator
ValeraS
left a comment
ValeraS
left a comment
There was a problem hiding this comment.
Please add eslint rule to config
{
selector: "MemberExpression[object.name='React'][property.name='useLayoutEffect']",
message: "Please use 'src/hooks/useLayoutEffect' instead.",
},| @@ -0,0 +1,3 @@ | |||
| import * as React from 'react'; | |||
Collaborator
There was a problem hiding this comment.
Let's move the file to public hooks and rename it to useLayoutEffect.ts.
monochromer
force-pushed
the
isomorphic-theme-provider
branch
from
db32e13 to
6007a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use server side rendering and
useLayoutEffectspam into our logs with message: